Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1148#discussion_r50638624
--- Diff:
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
---
@@ -2841,8 +2841,9 @@ private boolean
manageSecurityPolicy(SecurityPolicyType type, SrxCommand command
action = "<permit></permit>";
}
- xml = replaceXmlValue(xml, "action", action);
+
}
+ xml = replaceXmlValue(xml, "action", action);
--- End diff --
Why did you put it out of "if-then-else"?
Shouldn't it only be executed only if
"!type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
