Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-175630573
It is cultural; we have to stop duplicating lines; no matter where and no
matter how simple those blocks may seem.
We also have to stop coding things that are not needed as you did in the
test. If a code is not needed, why bother writing it down? I am referring to
the âaccountVO.setIdâ and accountVO.setDomainIdâ at the tests you wrote.
I do not know if ACS has a guideline for that, for me, it looks like common
sense. That was my opinion, but if others here are ok with the duplication of
lines, feel free to merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
