Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362068
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM
vm, final String vmName) th
}
}
+ protected String skipOrRemoveSR(Connection conn, SR sr) {
--- End diff --
@DaanHoogland I thought that your point was with the fact of being a
protected method (not with the fact of being self-explanatory).
Sorry, but when I said, "Is this method self-explanatory?" I meant about
the name of it, which I think is self-explanatory (says exactly what it does).
Although a documentation could (not should) be applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
