Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1413#issuecomment-183729063
  
    LGTM
    
    Master router:
    
![pr1413_router1](https://cloud.githubusercontent.com/assets/1630096/13029502/bb27f23c-d28e-11e5-9060-ebce22b3f9e7.png)
    
    Backup router before master destroy:
    
![pr1413_router2_before](https://cloud.githubusercontent.com/assets/1630096/13029504/c6da2776-d28e-11e5-8cee-d5e1fc24e81f.png)
    
    Backup now master:
    
![pr1413_router2_after](https://cloud.githubusercontent.com/assets/1630096/13029507/cfb1ba62-d28e-11e5-8dd4-f60cb38ad62d.png)
    
    What works fine now (and was broken before):
    - eth2 (private gw) is only UP on master (used to be both UP on 
master/backup)
    - eth2 has unique mac addresses on each router (used to be the same)
    - a crash of router brings up private gw on new master
    
    Integration tests are running as we spreak.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to