Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/874#discussion_r52846753
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -680,6 +680,13 @@ public Discoverer getMatchingDiscover(final
Hypervisor.HypervisorType hypervisor
}
}
+ if
((hypervisorType.equalsIgnoreCase(HypervisorType.BareMetal.toString()))) {
+ if (hostTags == null || hostTags.size() == 0) {
--- End diff --
Hey @harikrishna-patnala just a little tip on line 684. You could use
Apache Commons' CollectionUtils to make such checks, it does exactly the same
thing but is a little more clean. But that's just a little adjustment.
http://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/CollectionUtils.html#isEmpty(java.util.Collection)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
