Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-183970215
@bhaisaab Did you get to see the output of the jenkins build? Was it just
another false positive? I don't see anything in the code that could cause it to
fail...
But, if I may make a small suggestion, I'd ask you to extract the contents
from that if statement beginning at line 1799 to its own method, just to help
out with readability, as the sheer amount of conditionals involved in the
original method can make it a bit overwhelming to read. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
