Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1425#issuecomment-190430298
@nvazquez ,
Lines 191-195 and 261-265 are duplicated, could you extract it to a method?
And maybe even document it.
At the âResourceTagJoinVOâ, why did you create that new constructor?
Additionally, have you tested that view select? It looks ok, but I did not
check clause per clause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
