Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198881402
This PR has some nice improvements, so that's great @rafaelweingartner!
Still, I'm clueless why people merge without running a single integration
test. When doing so, you risk making master unstable. You simply don't know if
you broke something else unintentionally. When you run integration tests on
another PR later on and that fails, you don't know whether it's that PR or it
was master. We've been there, it's a pain. I'll leave it up to @swill to decide
as I'm no longer RM. I'd have reverted it, for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
