Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1465#discussion_r58927993
  
    --- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
    @@ -300,6 +303,8 @@ public ExecutionResult createFileInVR(final String 
routerIp, final String path,
             final File permKey = new File("/root/.ssh/id_rsa.cloud");
             String error = null;
     
    +        s_logger.debug("Creating file in VR " + filename);
    --- End diff --
    
    Please wrap in a ``if (s_logger.isDebugEnabled())`` block to avoid 
unnecessary string concatenation when not logging at ``DEBUG`` level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to