Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59419363
--- Diff: tools/marvin/marvin/cloudstackConnection.py ---
@@ -143,7 +143,7 @@ def __sign(self, payload):
["=".join(
[str.lower(r[0]),
str.lower(
- urllib.quote_plus(str(r[1]))
+ urllib.quote_plus(str(r[1]), safe="*")
--- End diff --
This is ported from cloudmonkey --
https://github.com/apache/cloudstack-cloudmonkey/pull/11/files
When tests send * in the cmd arg, test failures happened due to how url
encoding differs across ACS specific Java code and Python
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
