Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-209222090
I am confused as to the issue at this point. Building the PR using ``mvn
clean install findbugs:check`` passes. It appears that commit reversions have
addressed the issues. Assuming I ran the appropriate, I don't see why static
analysis should be blocking the progress of this PR.
@koushik-das ``@SuppressWarnings`` will hide the issue forever because, in
reality, we will never come back to it. Therefore, it should never be used if
we intend for static analysis to be useful/valuable practice
@swill Speaking generally, my opinion is that the suggestion does not work.
The point of static analysis is to protect the integrity of the codebase. If
a patch introduces a new issue, it shouldn't be accepted until the issue is
fixed. The only exception to this rule is that we determine the rule is no
longer valuable and stop checking it. We only gain value from static analysis
if we are disciplined about addressing the issues found rather than taking the
most expedient path to get a pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
