Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59787197
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java
---
@@ -196,5 +204,8 @@ private void validateParams() {
if(StringUtils.isEmpty(getPassword())) {
throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Empty
passwords are not allowed");
}
+ if (getAccountType() == null && getRoleId() == null) {
--- End diff --
Consider splitting these checks to give a more precise error message to the
end user. Also, shouldn't check that ``roleId`` is greater than ``0L``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
