Hi,

I noticed an issue in Marvin the other day and I tracked it to this commit:


https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d


The problem is that it assumes the "ispublic" parameter will be provided. If it 
is not, then an exception is thrown.


I think we want code more like this:


        if "ispublic" in services:
            cmd.ispublic = services["ispublic"]


I don't think we would want to require the "ispublic" parameter in Marvin. It's 
not required in our API:


http://cloudstack.apache.org/api/apidocs-4.8/root_admin/createTemplate.html?


Unless someone can think of a reason why this part of the code is the way it is 
now, I plan to open a PR to fix this soon.


Thanks,

Mike

Reply via email to