Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1497#discussion_r59917535
--- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
@@ -1790,6 +1802,10 @@
sc.setParameters("display", display);
}
+ if (ids != null && !ids.isEmpty()) {
--- End diff --
What about extracting line 1805 - 1808 to a method. Those lines are the
same as the ones at 3172-3175. then, you could also write test cases and add
java doc for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
