Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60771374
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
---
@@ -119,6 +131,9 @@ private Long getDomainId() {
@Override
public void execute() throws ServerApiException {
+ if (getAccountType() == null && getRoleId() == null) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both
account type and role ID are not provided");
--- End diff --
@jburwell because of backward compatibility we cannot make roleid param as
required, while accounttype used to be required but is now made non-required;
this checks ensures that at least one of them is passed. When only account type
is passed, we translate that to one of the four default roles (id).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
