Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60881906
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
---
@@ -70,10 +72,12 @@
@Parameter(name = ApiConstants.ACCOUNT_TYPE,
type = CommandType.SHORT,
- required = true,
--- End diff --
@jburwell see here ^^, accountype was a required arg but with our changes
we've made it non-required also added the roleId arg. Therefore, at least one
of the two must be provided, if both are provided we consider roleId (and
account type of the role).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
