Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-216192751
That seems fair... But I think you could make 3 unit tests instead of 1 so
each one would have only 1 assert and only one behavior each. Other than that
it all looks fine. As Daan said, the code seems sane and the tests prove it's
functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
