Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r62006414
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
view, String objectName, Us
userVmResponse.setNetworkKbsWrite((long)vmStats.getNetworkWriteKBs());
- if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer))) { // support KVM
and XenServer only util 2013.06.25
+ if ((userVm.getHypervisorType() != null) &&
(userVm.getHypervisorType().equals(HypervisorType.KVM) ||
userVm.getHypervisorType().equals(HypervisorType.XenServer) ||
userVm.getHypervisorType().equals(HypervisorType.VMware))) { // support KVM and
XenServer only util 2013.06.25 . supporting Vmware from 2015.09.02
--- End diff --
I removed the HV checks and ran it on a simulator and worked as expected,
returned 0 for the newly added fields in response. Since this is supposed to
work for XS, KVM, VMware anyways, and simulator works as well, guess the check
can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
