Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-217842674
as @pedro-martins stated, it seems to be fitting that this method is
extracted to a class to be documented/tested. The code looks good but if the
exception is to be launched I see no room for backward compatibility. If that's
an issue, this needs to be rethinked as the raised exception would have to be
treated and at that point we would have to think if raising the exception was
really necessary. Overall the code looks good, simple and justified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
