Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62511172
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -91,18 +280,5 @@ public boolean hostConnect(long hostId, long
storagePoolId) {
assert (answer instanceof ModifyStoragePoolAnswer) :
"ModifyStoragePoolAnswer expected ; Pool = " + storagePool.getId() + " Host = "
+ hostId;
--- End diff --
Off topic but I wanted to know what is the take on asserts? Personally I
love asserts but not sure what the community thinks of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
