Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62763676
  
    --- Diff: engine/components-api/src/com/cloud/network/vpc/VpcManager.java 
---
    @@ -161,8 +161,9 @@
          * @param gateway
          * @param networkOwner TODO
          */
    -        void
    -        validateNtwkOffForNtwkInVpc(Long networkId, long newNtwkOffId, 
String newCidr, String newNetworkDomain, Vpc vpc, String gateway, Account 
networkOwner, Long aclId);
    +    void validateNtwkOffForNtwkInVpc(Long networkId, long newNtwkOffId, 
String newCidr, String newNetworkDomain, Vpc vpc, String gateway, Account 
networkOwner, Long aclId);
     
         List<PrivateGateway> getVpcPrivateGateways(long vpcId);
    +
    +    CIDR[] getZoneSuperCidrList(long zoneId) throws BadCIDRException;
    --- End diff --
    
    Why is the list of super CIDRs being represented as an array instead of a 
``List``, ``Set``, or custom collected type for ``CIDR``s?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to