Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62786497
  
    --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
    @@ -903,6 +906,10 @@ static boolean areCidrsNotEmpty(String cidrA, String 
cidrB) {
     
         }
     
    +    public static Long[] cidrToLong(final CIDR ocidr) {
    +        return cidrToLong(ocidr.toString());
    +    }
    --- End diff --
    
    Why is this method implemented here rather than on ``CIDR`` class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to