Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62886608
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -2351,17 +2376,52 @@ public SR getIscsiSR(final Connection conn, final
String srNameLabel, final Stri
throw new CloudRuntimeException(msg, e);
}
}
+
deviceConfig.put("SCSIid", scsiid);
- final String result = SR.probe(conn, host, deviceConfig,
type, smConfig);
+ String result = SR.probe(conn, host, deviceConfig, type,
smConfig);
+
String pooluuid = null;
+
if (result.indexOf("<UUID>") != -1) {
pooluuid = result.substring(result.indexOf("<UUID>") +
6, result.indexOf("</UUID>")).trim();
}
if (pooluuid == null || pooluuid.length() != 36) {
sr = SR.create(conn, host, deviceConfig, new Long(0),
srNameLabel, srNameLabel, type, "user", true, smConfig);
- } else {
+ }
+ else {
+ if (resignature) {
--- End diff --
maybe a method createIfResignable()? thsi file is a blob of blobs, let's
get to reducing the problem called CitrixResourceBase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
