Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219709644
@DaanHoogland is correct; we're running this code in test-production. Keep
in mind however that we only use Basic Networking Zones, so I did my best to
keep the behaviour in other circumstances (barring obvious bugs) the same, but
I can't test those either.
Regarding @ustcweizhou 's comment; the only change I perceive there is
that, analogous to what's in the CsGuestNetwork, the code seems to imply that
the guest_gateway_ip will be added as DNS server in the case the SysVM is
either a VPC or a redundant router.
As I encountered a merge conflict while building this PR, I think this is a
relatively new conditional which seems to mirror the one (incorrectly) in
CsGuestNetwork (one depends on the is_vpc() or is_redundant(), the other
depends on the availability of the `router_guest_gateway` key).
If this both is true, I propose to change the `has_dns()` method to
incorporate this logic and merge the same decision in CsGuestNetwork with that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
