Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r63850026
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString() {
}
}
- public static class VirtioSerialDef {
- private final String _name;
+ public static class ChannelDef {
+ enum ChannelType {
+ UNIX("unix"), SERIAL("serial");
+ String _type;
--- End diff --
also, we can consider dropping the `_` as variable prefix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
