Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -19,173 +19,43 @@
package com.cloud.agent.api.element;
-import com.cloud.agent.api.CmdBuilder;
import com.cloud.agent.api.Command;
+import net.nuage.vsp.acs.client.api.model.VspAclRule;
+import net.nuage.vsp.acs.client.api.model.VspNetwork;
import java.util.List;
-import java.util.Map;
public class ApplyAclRuleVspCommand extends Command {
- private final boolean _networkAcl;
- private final String _networkUuid;
- private final String _networkDomainUuid;
- private final String _vpcOrSubnetUuid;
- private final String _networkName;
- private final boolean _isL2Network;
- private final List<Map<String, Object>> _aclRules;
- private final long _networkId;
- private final boolean _egressDefaultPolicy;
- private final Boolean _acsIngressAcl;
+ private final VspAclRule.ACLType _aclType;
+ private final VspNetwork _network;
+ private final List<VspAclRule> _aclRules;
--- End diff --
I am assuming that VspNetwork, VspAclRule etc. are all serialisable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
