[GitHub] cloudstack pull request: CLOUDSTACK-9368: DS template copies don�...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1560#issuecomment-221409198
  
    Hi @nvazquez, 
    
    Thanks for the PR. Great work as always, especially on documenting the 
problem.
    
    I think we can improve it a little bit. What about extracting lines 
5480-5485 to a method? Then, those java comments can become java docs (which I 
believe are much better) and also you would be able to write test cases.
    
    Also, I think we should change the “throw new Exception()” to a more 
specific exception. What about the CloudRuntimeException or another one?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---