GitHub user romain-dartigues opened a pull request:
https://github.com/apache/cloudstack/pull/1575
systemvm - Python code cleanup
While debugging an issue on the System VM (to be reported later once we
will have validated it behaviour); I took the opportunity to make some minor
code clean-up in the Python scripts in the System-VM.
Are you open to discuss about the future (improvements, conformance,
automated testing) of thoses scripts? Have you something already planned on
your side?
Regards.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romain-dartigues/cloudstack systemvm-pylint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1575
----
commit fc1b1c48ed1c345af0ed4d9c680dc079cb40749c
Author: Romain Dartigues <[email protected]>
Date: 2016-05-31T10:13:45Z
systemvm: make pylint happy
Mostly removing unused modules, but also defined some missing variables.
commit 5d4c39184c103902108c3ac2e4f96f7ec5dc99c4
Author: Romain Dartigues <[email protected]>
Date: 2016-05-31T10:54:33Z
systemvm: set_redundant.py non-working script
Deleting set_redundant.py as it can not work (call config.set_cl() and
config.get_cmdline() which are nowhere to be found).
commit e863e968fd8233d1df929b3d333c87fccfda0c18
Author: Romain Dartigues <[email protected]>
Date: 2016-05-31T13:08:39Z
systemvm: pylint conformance work in progress
I kept the changes at the minimum to make pylint happy,
I don't expect regressions.
Using default configuration:
> Your code has been rated at 8.92/10 (previous run: 7.81/10, +1.11)
* pylint 1.5.5,
* astroid 1.4.5
* Python 2.7.11 (default, Feb 22 2016, 09:22:43)
* [GCC 4.8.2]
Previous run is before the patch:
+-----------+--------+-------+----------+------------+
| type | number | % | previous | difference |
+===========+========+=======+==========+============+
| code | 3569 | 64.76 | 3582 | -13.00 |
+-----------+--------+-------+----------+------------+
| docstring | 356 | 6.46 | 330 | +26.00 |
+-----------+--------+-------+----------+------------+
| comment | 773 | 14.03 | 788 | -15.00 |
+-----------+--------+-------+----------+------------+
| empty | 813 | 14.75 | 820 | -7.00 |
+-----------+--------+-------+----------+------------+
+------------+--------+----------+------------+
| type | number | previous | difference |
+============+========+==========+============+
| convention | 261 | 466 | -205 |
+------------+--------+----------+------------+
| refactor | 28 | 48 | -20 |
+------------+--------+----------+------------+
| warning | 43 | 185 | -143 |
+------------+--------+----------+------------+
| error | 4 | 5 | -1 |
+------------+--------+----------+------------+
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
