Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1602#discussion_r69485338
  
    --- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ---
    @@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm, 
DeployDestination dest) throws Sto
                 disk.setDetails(getDetails(volumeInfo, dataStore));
     
                 vm.addDisk(disk);
    +
    +            // If hypervisor is vSphere, check for clone type setting.
    +            if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
    --- End diff --
    
    Does this need to be specific to VMWare? I can see a use case where this 
can be useful for XenServer as well. IIRC for XenServer, the volumes are 
`linked`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to