GitHub user leprechau reopened a pull request:
https://github.com/apache/cloudstack/pull/1608
Cleanup RBD contexts after exceptions to prevent potential agent crash
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine that the previously allocated contexts
are not cleaned up. This seemed to cause an eventual crash of the host
agent after multiple exceptions within the loop.
In addition to ensuring the contexts are always freed we also improved
the logging when exceptions do occur to include the actual return code
from the underlying library in deletePhysicalDisk and deleteSnapshot.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack upstream/context-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1608
----
commit 44491448e3811cfcebe5c3aeee72ba7a01948cda
Author: Aaron Hurt <[email protected]>
Date: 2016-07-09T03:57:06Z
Cleanup rbd contexts and improve exception logging
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine that the previously allocated contexts
are not cleaned up. This seemed to cause an eventual crash of the host
agent after multiple exceptions within the loop.
In addition to ensuring the contexts are always freed we also improved
the logging when exceptions do occur to include the actual return code
from the underlying library in deletePhysicalDisk and deleteSnapshot.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
