Github user mike-tutkowski commented on the issue:

    https://github.com/apache/cloudstack/pull/1600
  
    A comment:
    
    
    I have observed that the SR that was previously not being detached from 
XenServer is now being detached with your newer version of the code.
    
    
    One thing I noticed in the DB:
    
    
    In the snapshot_store_ref table, we still have a row for the snapshot that 
indicates there is a version of the snapshot on primary storage. We also - 
correctly - have a row indicating that there is a version of the snapshot on 
secondary storage.
    
    
    I think we should remove the row from the snapshot_store_ref table that 
links the snapshot to a version on primary storage.
    
    
    ________________________________
    From: Tutkowski, Mike
    Sent: Monday, July 4, 2016 1:24 PM
    To: apache/cloudstack
    Cc: apache/cloudstack; Mention
    Subject: Re: [apache/cloudstack] Support Backup of Snapshots for Managed 
Storage (#1600)
    
    My mistake. I forgot that I added that a while ago. :)
    
    On Jul 4, 2016, at 12:40 PM, Syed Mushtaq Ahmed 
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
    
    
    @mike-tutkowski<https://github.com/mike-tutkowski> , the list snapshot 
already returns the loacationType. I think you've already added that.
    
    -
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/cloudstack/pull/1600#issuecomment-230340112>, 
or mute the 
thread<https://github.com/notifications/unsubscribe/AC4SHwCngBVFvcsRcZLcRdKHyNBdMY2xks5qSVORgaJpZM4JCaMg>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to