Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73742358
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm,
DeployDestination dest) throws Sto
disk.setDetails(getDetails(volumeInfo, dataStore));
vm.addDisk(disk);
+
+ // If hypervisor is vSphere, check for clone type setting.
+ if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
+ // retrieve clone flag.
+ UserVmCloneType cloneType = UserVmCloneType.linked;
+ Boolean value =
CapacityManager.VmwareCreateCloneFull.valueIn(vol.getPoolId());
+ if (value != null) {
+ if (value.booleanValue() == true)
--- End diff --
Please collapse lines lines 1372 and 1373 into ``if (value != null &&
value)``. The compiler will autobox the ``Boolean`` instance -- removing the
requirement to call ``booleanValue``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
