Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74249850
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -234,6 +256,10 @@ public Integer getVncPort() {
return diskDefs;
}
+ public List<ChannelDef> getChannels() {
+ return channels;
--- End diff --
Please make a defensive copy of the list before returning to avoid
side-effects on this class by potential mutations of the list by the caller.
Ideally, return it as a ``Collections.unmodifiableList(channels)``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
