Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1640#discussion_r75758946
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
boolean fenced = false;
if (alive == null) {
- s_logger.debug("Fencing off VM that we don't know the
state of");
+ s_logger.debug("Fencing off VM " + vm + " that we
don't know the state of");
--- End diff --
In my view, the ``Supplier`` approach is just as complex, but in another
way. In the long term, we will be adopting SLF4J which supports string
templates -- allowing constructs as such as:
```
LOG.debug("I am having a problem VM %s", vm.getId());
```
This approach defers string concatenation in a more straight forward manner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
