Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1659#discussion_r76482410
  
    --- Diff: test/integration/smoke/test_multiple_public_ip_ranges.py ---
    @@ -0,0 +1,887 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +""" BVT tests for network services on public IP's from different public IP
    +  range than that of associated source NAT IP of the network. Each IP 
associated
    +  with network from a different public IP range results in a new public
    +  interface on VR (eth3, eth4 etc) and iptable
    +"""
    +# Import Local Modules
    +from marvin.codes import (FAILED, STATIC_NAT_RULE, LB_RULE,
    +                          NAT_RULE, PASS)
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.cloudstackException import CloudstackAPIException
    +from marvin.cloudstackAPI import rebootRouter
    +from marvin.sshClient import SshClient
    +from marvin.lib.utils import cleanup_resources, get_process_status
    +from marvin.lib.base import (Account,
    +                             VirtualMachine,
    +                             ServiceOffering,
    +                             NATRule,
    +                             PublicIPAddress,
    +                             StaticNATRule,
    +                             FireWallRule,
    +                             Network,
    +                             NetworkOffering,
    +                             LoadBalancerRule,
    +                             PublicIpRange,
    +                             Router,
    +                             VpcOffering,
    +                             VPC,
    +                             NetworkACL)
    +from marvin.lib.common import (get_domain,
    +                               get_zone,
    +                               get_template,
    +                               list_hosts,
    +                               list_publicIP,
    +                               list_nat_rules,
    +                               list_routers,
    +                               list_virtual_machines,
    +                               list_lb_rules,
    +                               list_configurations,
    +                               verifyGuestTrafficPortGroups)
    +from nose.plugins.attrib import attr
    +from ddt import ddt, data
    +# Import System modules
    +import socket
    +import time
    +import logging
    +
    +_multiprocess_shared_ = True
    +
    +logger = logging.getLogger('TestNetworkOps')
    +stream_handler = logging.StreamHandler()
    +logger.setLevel(logging.DEBUG)
    +logger.addHandler(stream_handler)
    +
    +class TestPortForwarding(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +
    +        testClient = super(TestPortForwarding, cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls.services = testClient.getParsedTestDataConfig()
    +        cls.hypervisor = testClient.getHypervisorInfo()
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +        cls.services["virtual_machine"]["zoneid"] = cls.zone.id
    +        cls.services["zoneid"] = cls.zone.id
    +        template = get_template(
    +            cls.apiclient,
    +            cls.zone.id,
    +            cls.services["ostype"]
    +        )
    --- End diff --
    
    @abhinandanprateek is this the best way to determine the default template 
for VMs in a Marvin test suite?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to