Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1624#discussion_r77326112
  
    --- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
    @@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account, 
long callerUserId, Account c
                         s_logger.error("Unable to expunge vm: " + vm.getId());
                         accountCleanupNeeded = true;
                     }
    +                else if 
(!vm.getState().equals(VirtualMachine.State.Destroyed)) {
    +                    // We have to emit the event here because the state 
listener is ignoring root volume deletions,
    +                    // assuming that the UserVMManager is responsible for 
emitting the usage event for them when
    --- End diff --
    
    Why not fix the state listener, or the manager that is responsible for 
emitting the event in the first place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to