Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1604#discussion_r77684266
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsHelper.py ---
@@ -179,12 +179,12 @@ def get_hostname():
return line.strip()
-def execute(command):
+def execute(command, wait=True):
""" Execute command """
logging.debug("Executing: %s" % command)
p = subprocess.Popen(command, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, shell=True)
- result = p.communicate()[0]
- return result.splitlines()
+ if wait:
+ return p.communicate()[0].splitlines()
--- End diff --
What happens if the command does not return? It seems like there should be
a wait period to timeout operations that run too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
