Kris, Looking at the history of the PR, there appears to be one LGTM for testing the PR scope. Given the size of the change, it seems appropriate to run a regression test. However, there are no results indicating a regression test has been run.
I also reviewed the code and left comments to move towards getting a code review LGTM. Thanks, -John > john.burw...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK @shapeblue On Sep 6, 2016, at 3:10 PM, Kris Sterckx <kris.ster...@nuagenetworks.net> wrote: > > Thanks Rajani > > https://github.com/apache/cloudstack/pull/1578 has votes and tests pass. > > What would be the next step ? > > Best, > > Kris > > > > On 30 August 2016 at 07:24, Rajani Karuturi <raj...@apache.org> wrote: > >> If you could get 2 LGTMs(any one from your team can also review >> and give LGTM) and if you can run BVT suite on >> PR(https://github.com/apache/cloudstack/tree/master/test/integration/smoke >> ), >> they can be immediately merged. >> >> ~ Rajani >> http://cloudplatform.accelerite.com/ >> >> On August 30, 2016 at 3:47 AM, Kris Sterckx >> (kris.ster...@nuagenetworks.net) wrote: >> Hi All, >> >> The Nuage Networks team is investing in ACS 4.10.0 and has >> several feature >> PR's outstanding for review : >> >> - https://github.com/apache/cloudstack/pull/1578 >> - https://github.com/apache/cloudstack/pull/1580 >> - https://github.com/apache/cloudstack/pull/1579 >> - https://github.com/apache/cloudstack/pull/1577 >> >> How can we better facilitate the review of these PR's ? >> >> Thanks, >> >> - Kris >> >> -- >> Kris Sterckx >> >> CloudStack Development Lead >> >> Nuage Networks >>
