Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1673#discussion_r79316781
  
    --- Diff: server/src/com/cloud/server/StatsCollector.java ---
    @@ -285,9 +286,15 @@ private void init(Map<String, String> configs) {
                         s_logger.info(scheme + " is not a valid protocol for 
external statistics. No statistics will be send.");
    --- End diff --
    
    I realize it is out of scope for this PR, but would mind changing the log 
level to ``WARN`` for this message?  It is clearly a user intent that is not 
going to be carried through due to bad configuration data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to