Github user mike-tutkowski commented on the issue:
@jburwell Let me provide a bit of additional background for this PR.
As noted in the initial comment, it was possible to spin up system VMs on
managed storage prior to this PR.
This PR adds three items:
1) There are a couple checks added when creating a system offering that
uses managed storage. For example, it doesn't really make sense to allow
"custom IOPS" and now we prevent that if you try to create a system offering as
2) If you transition managed storage into maintenance mode and system VMs
were running on that managed storage, the host-side clustered file systems (SRs
on XenServer) were not removed. This is not a big issue since putting a managed
storage like a SAN in maintenance mode is not too likely.
I added a call to a method that removes these client-side file systems, if
you're using managed storage. In the event of any failure here, I catch the
exception, print an error message to the log, and allow the storage-cleanup
thread to continue its tasks.
3) I added an extensive set of tests with regards to system VMs on managed
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket