GitHub user murali-reddy opened a pull request:
https://github.com/apache/cloudstack/pull/1680
CLOUDSTACK-9498: VR CsFile search utility methods fail when search stâ¦
There is no real use of python 're' module in CsFile.py utility methods
searchString, deleteLine. Regular string search is sufficient. These methods
are used only for VPN user add/delete. Since VPN user password can have python
're' module meta characters, it interfere with search functionality.
Replacing re.search() with regular string search instead.
Change is confined to VPN add/delete users. Have run the
test/integration/component/test_vpn_users.py
VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit
| Status : SUCCESS ===
ok
Test create VPN when L2TP port in use ... === TestName:
test_02_use_vpn_port | Status : SUCCESS ===
ok
Test create NAT rule when VPN when L2TP enabled ... === TestName:
test_03_enable_vpn_use_port | Status : SUCCESS ===
ok
Test add new users to existing VPN ... === TestName: test_04_add_new_users
| Status : SUCCESS ===
ok
Test add duplicate user to existing VPN ... === TestName:
test_05_add_duplicate_user | Status : SUCCESS ===
ok
Test as global admin, add a new VPN user to an existing VPN entry ... ===
TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
ok
Test as domain admin, add a new VPN user to an existing VPN entry ... ===
TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
ok
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/murali-reddy/cloudstack vr_csfile_search
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1680
----
commit 352835873279ae966f889b290ff79587dcea1c11
Author: Murali Reddy <[email protected]>
Date: 2016-09-20T20:39:16Z
CLOUDSTACK-9498: VR CsFile search utility methods fail when search string
has char *, + etc
there is no real use of python 're' in CsFile.py utility methods
searchString, deleteLine
Replacing with regular string search instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
