Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80404569
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java
---
@@ -87,7 +88,7 @@ public Answer execute(final PvlanSetupCommand command,
final LibvirtComputingRes
} else if (command.getType() == PvlanSetupCommand.Type.VM) {
final String ovsPvlanVmPath =
libvirtComputingResource.getOvsPvlanVmPath();
- final Script script = new Script(ovsPvlanVmPath, timeout,
s_logger);
+ final Script script = new Script(ovsPvlanVmPath,
timeout.getMillis(), s_logger);
--- End diff --
@jburwell yes you are right, we should modify the script class to take
duration as timeout instead of long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
