Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r84285865
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -543,9 +543,12 @@ def configure_ipsec(self, obj):
secret.commit()
file.commit()
logging.info("Configured vpn %s %s", leftpeer, rightpeer)
- CsHelper.execute("ipsec reload")
- if not obj['passive']:
- CsHelper.execute("sudo nohup ipsec up vpn-%s &" %
rightpeer)
+ CsHelper.execute("ipsec rereadsecrets")
+
+ CsHelper.execute("ipsec reload")
+ if not obj['passive']:
+ CsHelper.execute("sudo nohup ipsec down vpn-%s " % rightpeer)
+ CsHelper.execute("sudo nohup ipsec up vpn-%s &" % rightpeer)
--- End diff --
By doing this in the background, won't the `up` be run right away instead
of waiting for the `down` to finish running? We don't do it this way in
`deletevpn()`, why are we doing it this way here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
