Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1730#discussion_r87170352
--- Diff:
engine/schema/src/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java ---
@@ -84,14 +84,11 @@ public VMTemplateZoneVO findByZoneTemplate(long zoneId,
long templateId) {
}
@Override
+ @DB
public void deletePrimaryRecordsForTemplate(long templateId) {
SearchCriteria<VMTemplateZoneVO> sc = TemplateSearch.create();
sc.setParameters("template_id", templateId);
- TransactionLegacy txn = TransactionLegacy.currentTxn();
--- End diff --
I looked a bit more into that, and `@DB` use the same class as
`TransactionLegacy`, which is different than `Transaction`. The change
f62e28c1ec125263613d32856b11ef50b815e573 added a new transaction API.
Having the annotation or the line of code to create the transaction is
similar. IMO the annotation is cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
