Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r89533059
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -175,6 +180,26 @@ public boolean parseDomainXML(String domXML) {
interfaces.add(def);
}
+ NodeList ports = devices.getElementsByTagName("channel");
+ for (int i = 0; i < ports.getLength(); i++) {
+ Element channel = (Element)ports.item(i);
+
+ String type = channel.getAttribute("type");
+ String path = getAttrValue("source", "path", channel);
+ String name = getAttrValue("target", "name", channel);
+ String state = getAttrValue("target", "state", channel);
+
+ ChannelDef def = null;
+ if (!StringUtils.isNotBlank(state)) {
--- End diff --
This is fine, though you can use guava's Strings.isNullOrEmpty, which is
what I've been using in most of my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
