[GitHub] cloudstack pull request #1797: CLOUDSTACK-9630: Cannot use listNics API as a...

[sudhansu7]

GitHub user sudhansu7 opened a pull request:

    https://github.com/apache/cloudstack/pull/1797

    CLOUDSTACK-9630: Cannot use listNics API as advertised

    
    
    listNics API for a VM, "type" was not returned within API response.
    
    EXPECTED BEHAVIOR
    ==================
    The listNics API response return type of NIC (type), as specified in 
https://cloudstack.apache.org/api/apidocs-4.8/user/listNics.html
    
    ACTUAL BEHAVIOR
    ==================
    The listNics API response does not return type of NIC.
    
    (local) 🐵 > list nics 
virtualmachineid=a69edaf5-8f21-41ff-8c05-263dc4bd5354
    count = 1
    nic:
    id = 211e0d46-6b94-4425-99f7-e8e9efea2472
    deviceid = 0
    gateway = 10.1.1.1
    ipaddress = 10.1.1.45
    isdefault = True
    macaddress = 02:00:06:f6:00:01
    netmask = 255.255.255.0
    networkid = c08fddf1-fd77-4810-a062-ea9d03c5c7e6
    virtualmachineid = a69edaf5-8f21-41ff-8c05-263dc4bd5354
    
    Solution:
    added "type" details for listNics API response.
    
    After Fix:
    
    (local) 🐵 > list nics 
virtualmachineid=a69edaf5-8f21-41ff-8c05-263dc4bd5354 
    count = 1
    nic:
    id = 211e0d46-6b94-4425-99f7-e8e9efea2472
    broadcasturi = vlan://743
    deviceid = 0
    gateway = 10.1.1.1
    ipaddress = 10.1.1.45
    isdefault = True
    isolationuri = vlan://743
    macaddress = 02:00:06:f6:00:01
    netmask = 255.255.255.0
    networkid = c08fddf1-fd77-4810-a062-ea9d03c5c7e6
    traffictype = Guest
    **type = Isolated**
    virtualmachineid = a69edaf5-8f21-41ff-8c05-263dc4bd5354

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-9630

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1797
    
----
commit f5e6136265580af069879bcb5b9cb86646f79ea9
Author: Sudhansu <sudhansu.s...@accelerite.com>
Date:   2016-11-29T08:44:24Z

    CLOUDSTACK-9630: Cannot use listNics API as advertised
    
    added "type" details for listNics API response.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---