Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450669
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static final Map<Service, Map<Capability, String>>
capabilities = setCapabilities();
+ private static final Set<Service> REQUIRED_SERVICES = Sets.newHashSet(
+ Service.Connectivity,
+ Service.Dhcp
+ );
+ private static final Set<Service> NUAGE_ONLY_SERVICES =
Sets.newHashSet(
+ Service.SourceNat,
+ Service.StaticNat,
+ Service.Gateway
+ );
+ private static final Set<Service> UNSUPPORTED_SERVICES =
Sets.newHashSet(
+ Service.Vpn,
+ Service.Dns,
+ Service.PortForwarding,
+ Service.SecurityGroup
+ );
+ private static final Set<Pair<Service, Service>> ANY_REQUIRED_SERVICES
= Sets.newHashSet(
--- End diff --
Since this value is constant, please use ``ImmutableSet`` rather than
``HashSet``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
