Github user sgoeminn commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,310 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import java.util.HashMap;
    +import java.util.Map;
    +import javax.naming.ConfigurationException;
    +import net.nuage.vsp.acs.client.api.model.NuageVspUser;
    +import net.nuage.vsp.acs.client.api.model.VspHost;
    +import net.nuage.vsp.acs.client.common.NuageVspApiVersion;
    +import org.apache.commons.lang.builder.ToStringBuilder;
    +public class NuageVspResourceConfiguration {
    --- End diff --
    It's conceptual far more clear with the current class. Furthermore, this 
class is not only a wrapper around a Map but also contains a Builder.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to