Github user jburwell commented on a diff in the pull request:
    --- Diff: server/src/com/cloud/storage/ ---
    @@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List<Volume> 
volumes, StoragePool pool,
             // allocated space includes templates
    +        s_logger.debug("Destination pool id: " + pool.getId());
    --- End diff --
    Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to 
prevent unnecessary/expensive string concatenation when `DEBUG` logging is not 
enabled.  Also, please add context to message to explain what operation is 
being performed for the destination pool.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to