Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1765#discussion_r90594670
  
    --- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
 ---
    @@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, 
final String path) {
             PBD pbd = null;
     
             try {
    -            final String srname = hypervisorResource.getHost().getUuid() + 
path.trim();
    -
    -            final Set<SR> srs = SR.getByNameLabel(conn, srname);
    -
    -            if (srs != null && !srs.isEmpty()) {
    -                return srs.iterator().next();
    +            final String srname = path.trim();
    --- End diff --
    
    The SR for a template that is to be copied to primary is temporarily 
mounted on Xen, after the copy is complete, it is unmounted and SR forgotten on 
Xen. The SR is temporary and for the current operation only. Having said that 
it does not really make a difference. @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to